CAPAUT-254 Fix review findings
This commit is contained in:
@@ -44,6 +44,7 @@ const dataParser = {
|
|||||||
* @returns
|
* @returns
|
||||||
*/
|
*/
|
||||||
parseData: function(data, topicPrefix) {
|
parseData: function(data, topicPrefix) {
|
||||||
|
let resultMessage = null
|
||||||
// Create mac address from first 5 bytes (reorder)
|
// Create mac address from first 5 bytes (reorder)
|
||||||
let deviceAddress = `${this.createMACPart(data[3])}:${this.createMACPart(data[2])}:${this.createMACPart(data[1])}:${this.createMACPart(data[0])}:${this.createMACPart(data[5])}:${this.createMACPart(data[4])}`
|
let deviceAddress = `${this.createMACPart(data[3])}:${this.createMACPart(data[2])}:${this.createMACPart(data[1])}:${this.createMACPart(data[0])}:${this.createMACPart(data[5])}:${this.createMACPart(data[4])}`
|
||||||
// Message type
|
// Message type
|
||||||
@@ -52,7 +53,7 @@ const dataParser = {
|
|||||||
let counter = ( ( data[6] & BITMASK_2_BYTES ) << 0 ) | ( ( data[7] & BITMASK_2_BYTES ) << 8 );
|
let counter = ( ( data[6] & BITMASK_2_BYTES ) << 0 ) | ( ( data[7] & BITMASK_2_BYTES ) << 8 );
|
||||||
// Process message of type 1 only
|
// Process message of type 1 only
|
||||||
if ( packetType == 0x01 ) {
|
if ( packetType == 0x01 ) {
|
||||||
let resultMessage = {
|
resultMessage = {
|
||||||
payload: {},
|
payload: {},
|
||||||
deviceAddress: deviceAddress,
|
deviceAddress: deviceAddress,
|
||||||
messageCounter: counter,
|
messageCounter: counter,
|
||||||
@@ -78,9 +79,8 @@ const dataParser = {
|
|||||||
resultMessage.payload[key] = { value: dataValue, topic: topic, description: valueDescriptor.description, unit: valueDescriptor.unit }
|
resultMessage.payload[key] = { value: dataValue, topic: topic, description: valueDescriptor.description, unit: valueDescriptor.unit }
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
return resultMessage
|
|
||||||
}
|
}
|
||||||
return null
|
return resultMessage
|
||||||
},
|
},
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
Reference in New Issue
Block a user