captica-oss/de.captica.nodered.node.systacomfort2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CAPAUT-254 Fix review findings

Browse Source
This commit is contained in:
Marc Böhm
2022-07-28 21:30:34 +02:00
parent 1114518ff3
commit 4884825357
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
systacomfort2/dataparser.js
View File

@@ -44,6 +44,7 @@ const dataParser = {
* @returns * @returns
*/ */
parseData: function(data, topicPrefix) { parseData: function(data, topicPrefix) {
let resultMessage = null
// Create mac address from first 5 bytes (reorder) // Create mac address from first 5 bytes (reorder)
let deviceAddress = `${this.createMACPart(data[3])}:${this.createMACPart(data[2])}:${this.createMACPart(data[1])}:${this.createMACPart(data[0])}:${this.createMACPart(data[5])}:${this.createMACPart(data[4])}` let deviceAddress = `${this.createMACPart(data[3])}:${this.createMACPart(data[2])}:${this.createMACPart(data[1])}:${this.createMACPart(data[0])}:${this.createMACPart(data[5])}:${this.createMACPart(data[4])}`
// Message type // Message type
@@ -52,7 +53,7 @@ const dataParser = {
let counter = ( ( data[6] & BITMASK_2_BYTES ) << 0 ) | ( ( data[7] & BITMASK_2_BYTES ) << 8 ); let counter = ( ( data[6] & BITMASK_2_BYTES ) << 0 ) | ( ( data[7] & BITMASK_2_BYTES ) << 8 );
// Process message of type 1 only // Process message of type 1 only
if ( packetType == 0x01 ) { if ( packetType == 0x01 ) {
let resultMessage = { resultMessage = {
payload: {}, payload: {},
deviceAddress: deviceAddress, deviceAddress: deviceAddress,
messageCounter: counter, messageCounter: counter,
@@ -77,10 +78,9 @@ const dataParser = {
} }
resultMessage.payload[key] = { value: dataValue, topic: topic, description: valueDescriptor.description, unit: valueDescriptor.unit } resultMessage.payload[key] = { value: dataValue, topic: topic, description: valueDescriptor.description, unit: valueDescriptor.unit }
} }
}) })
return resultMessage
} }
return null return resultMessage
}, },
/** /**